[core] Explicitly define exported subpaths #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
michaldudak
commented
Nov 25, 2024
•
michaldudak
commented
- Explicitly defined identifiers exported from the package, as we don't intend to make every top-level package subdirectory public.
- Removed babel and webpack package aliases. There is now a single place that defines them: tsconfig
- Updated the build scripts to transform the package.json exports.
Netlify deploy preview |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
michaldudak
commented
Nov 28, 2024
| @@ -2,6 +2,7 @@ | |||
| .nyc_output | |||
| /coverage | |||
| /docs/.next | |||
| /docs/data/**/*.js | |||
There was a problem hiding this comment.
No need to lint autogenerated files
michaldudak
commented
Nov 28, 2024
| @@ -1,263 +0,0 @@ | |||
| 'use client'; | |||
There was a problem hiding this comment.
Removed the two Slider experiments that use internal API
michaldudak
commented
Nov 28, 2024
Comment on lines
+54
to
+56
| "./unstable-no-ssr": "./src/unstable-no-ssr/index.ts", | ||
| "./unstable-use-media-query": "./src/unstable-use-media-query/index.ts", | ||
| "./utils": "./src/utils/index.ts" |
There was a problem hiding this comment.
Added the unstable- prefix to NoSsr and useMediaQuery as they are not documented yet (and their API might change).
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.